fix: always expose the mode selector and make the default model explicit #27

Closed
pi-agent wants to merge 0 commits from humane-wolverine into main
Collaborator

Superseded by #28: branch renamed to fix/mode-selector-and-default-model to follow Conventional Branch naming (type/description). Same commit 0ca2b44, same content.

Superseded by #28: branch renamed to fix/mode-selector-and-default-model to follow Conventional Branch naming (type/description). Same commit 0ca2b44, same content.
fix: always expose the mode selector and make the default model explicit
All checks were successful
code-review / Agent review (pull_request) Successful in 8s
0ca2b44663
Paseo lost the Fast/Default/Deep thinking selector after pi-deploy PR #69
removed the cortects provider from brainless.json: cortecs models sorted
first and declared reasoningEffort, so they were the registry default and
the catalog advertised modes. With them gone the default became the
non-reasoning local/gemma4:e2b, and the harness only advertised modes when
the default model reasoned (configOptions/modeState gated on
HasReasoningSelector of the active-or-default ref).

Three changes:

1. The mode selector is now always advertised at catalog time (no explicit
   model selection), so a non-reasoning default can no longer hide it for
   the reasoning models in the config. Per-model gating still applies once
   a model is explicitly selected: a model with no meaningful reasoning
   effort drops the selector, and applyModel/applyMode already fall back
   for presets a model cannot honor. notifyConfigChanged mirrors modeState.

2. New top-level config.default names the model fresh sessions start on as
   "provider/model"; omitted falls back to the first model in sorted
   order. Previously the default was implicit (first sorted entry), which
   is what made the cortects removal silently change the catalog. The
   model config option still lists every model, so default only seeds
   sessions and the catalog's current-value display. ExpandEnv now copies
   the field (it rebuilt File without it, which would have silently
   dropped a configured default).

3. history.lastTasks is unchanged: it stays off by default (nil block);
   the deployed config enabled it without a user request.
pi-agent closed this pull request 2026-10-09 21:51:16 +00:00
pi-agent left a comment
No description provided.
Superseded by #28: branch renamed to fix/mode-selector-and-default-model to follow Conventional Branch naming (type/description). Same commit 0ca2b44, same content.
All checks were successful
code-review / Agent review (pull_request) Successful in 8s

Pull request closed

Sign in to join this conversation.
No reviewers
No labels
code-review
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
sam/brainless!27
No description provided.